Skip to content

feat(settings): ThemePickerButton search filter (#114) - #145

Merged
ZhuchkaTriplesix merged 2 commits into
devfrom
issue/114-theme-picker-search
Jun 14, 2026
Merged

feat(settings): ThemePickerButton search filter (#114)#145
ZhuchkaTriplesix merged 2 commits into
devfrom
issue/114-theme-picker-search

Conversation

@ZhuchkaTriplesix

Copy link
Copy Markdown
Member

Summary

  • Add search field to ThemePickerButton popup with filterThemeDefinitions.
  • Filter by theme name, id, and source; show empty-state message when no matches.
  • Typing in search does not invoke onSelected.

Test plan

  • flutter test test/features/settings/theme_picker_button_test.dart

Closes #114

Filter registry rows by name, id, and source with a local search field and
empty-state message without applying themes while typing.
@github-actions github-actions Bot added theme Theming, colors, VS Code themes frontend Theme parser epic label: frontend settings Theme parser epic label: settings labels Jun 14, 2026
@github-actions github-actions Bot added this to the Theme system milestone Jun 14, 2026

@ZhuchkaTriplesix ZhuchkaTriplesix left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

123

@ZhuchkaTriplesix
ZhuchkaTriplesix merged commit 3280d13 into dev Jun 14, 2026
4 checks passed
@ZhuchkaTriplesix
ZhuchkaTriplesix deleted the issue/114-theme-picker-search branch June 15, 2026 04:13
ZhuchkaTriplesix added a commit that referenced this pull request Jul 27, 2026
feat(settings): ThemePickerButton search filter (#114)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend Theme parser epic label: frontend settings Theme parser epic label: settings theme Theming, colors, VS Code themes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant